main · last commit
17 hours ago ·
skqvdbd8
sr-ht-compare-65g Move compare's inline layout.html CSS into scss/main.scss
Lined Up
bd update sr-ht-compare-65g --claim
bd close sr-ht-compare-65g
| Created by | bigbes |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T21:37:44Z |
| Updated | 2026-08-17T21:37:44Z |
What is wrong: sourcehut-compare/web/templates/layout.html has a 28-line inline <style> block (the .diff-status* rules). sourcehut-compare's scss/main.scss is about 200 lines and contains no .diff-status rule at all — the two are unrelated to each other. (Companion finding: sourcehut-dolt has ~467 more lines of inline CSS across four templates, tracked separately in dolt's tracker.) Why it matters: inline CSS is re-sent on every page load, sits outside the hashed-asset immutable cache, cannot use the shared SCSS variables ($font-family-monospace, the dark palette), and — because it lives in layout.html specifically — is paid for on every single page compare serves, including the error page. compare already has a working 'make css' pipeline that the six other siblings use for exactly this content. Correct variant: the six services that keep everything in scss/main.scss below '@import "base"', e.g. repo/path sourcehut-tokens/scss/main.scss. Fix: move the .diff-status* rules from sourcehut-compare/web/templates/layout.html into sourcehut-compare/scss/main.scss, then delete the <style> block from layout.html. Audit: D37 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | sr-ht-compare-65g |
| content_hash | c3a07761c446057e82e20332a5c957ced1c742de31ad5dba2c95a43597585d38 |
| title | Move compare's inline layout.html CSS into scss/main.scss |
| description | What is wrong: sourcehut-compare/web/templates/layout.html has a 28-line inline <style> block (the .diff-status* rules). sourcehut-compare's scss/main.scss is about 200 lines and contains no .diff-status rule at all — the two are unrelated to each other. (Companion finding: sourcehut-dolt has ~467 more lines of inline CSS across four templates, tracked separately in dolt's tracker.) Why it matters: inline CSS is re-sent on every page load, sits outside the hashed-asset immutable cache, cannot use the shared SCSS variables ($font-family-monospace, the dark palette), and — because it lives in layout.html specifically — is paid for on every single page compare serves, including the error page. compare already has a working 'make css' pipeline that the six other siblings use for exactly this content. Correct variant: the six services that keep everything in scss/main.scss below '@import "base"', e.g. repo/path sourcehut-tokens/scss/main.scss. Fix: move the .diff-status* rules from sourcehut-compare/web/templates/layout.html into sourcehut-compare/scss/main.scss, then delete the <style> block from layout.html. Audit: D37 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 3 |
| issue_type | chore |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T21:37:44Z |
| created_by | bigbes |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T21:37:44Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a011a8-b51c-7e44-9fd5-23dab45c609e |
| issue_id | sr-ht-compare-65g |
| event_type | created |
| actor | bigbes |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-18T00:37:44Z |
No comments.