main · last commit
17 hours ago ·
skqvdbd8
sr-ht-compare-d4m Switch compare's template embed to the all:templates prefix
Lined Up
bd update sr-ht-compare-d4m --claim
bd close sr-ht-compare-d4m
| Created by | bigbes |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T21:37:46Z |
| Updated | 2026-08-17T21:37:46Z |
What is wrong: sourcehut-compare embeds its template tree with a bare glob, 'templates/*.html' (in the //go:embed directive), instead of the 'all:templates' directory-walk prefix that artifacts/bench/coverage/curator/tokens use (each with a comment noting the all: prefix is load-bearing). specs uses the same bare-glob form as compare; dolt uses a two-pattern glob ('templates/*.html templates/icons/*.svg').
Why it matters: nothing is broken today (a glob still picks up _-prefixed partials, unlike a directory walk), but the glob form is fragile going forward: a partial placed in a subdirectory, or any non-.html fragment, is silently NOT embedded and fails at request time as 'no such template' — dolt already had to add a second glob pattern for its icons/ subdirectory to work around exactly this.
Correct variant: 'all:templates', e.g. repo/path sourcehut-tokens's //go:embed directive over its templates tree.
Fix: change sourcehut-compare's //go:embed directive from 'templates/*.html' to 'all:templates'.
Audit: D39 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | sr-ht-compare-d4m |
| content_hash | 9ad11b77c76bb64020f443627f8a476d44a5bcd875cdf25af89c4d87b7fd0c84 |
| title | Switch compare's template embed to the all:templates prefix |
| description | What is wrong: sourcehut-compare embeds its template tree with a bare glob, 'templates/*.html' (in the //go:embed directive), instead of the 'all:templates' directory-walk prefix that artifacts/bench/coverage/curator/tokens use (each with a comment noting the all: prefix is load-bearing). specs uses the same bare-glob form as compare; dolt uses a two-pattern glob ('templates/*.html templates/icons/*.svg'). Why it matters: nothing is broken today (a glob still picks up _-prefixed partials, unlike a directory walk), but the glob form is fragile going forward: a partial placed in a subdirectory, or any non-.html fragment, is silently NOT embedded and fails at request time as 'no such template' — dolt already had to add a second glob pattern for its icons/ subdirectory to work around exactly this. Correct variant: 'all:templates', e.g. repo/path sourcehut-tokens's //go:embed directive over its templates tree. Fix: change sourcehut-compare's //go:embed directive from 'templates/*.html' to 'all:templates'. Audit: D39 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 3 |
| issue_type | chore |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T21:37:46Z |
| created_by | bigbes |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T21:37:46Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a011a8-ba5c-7a7b-9345-8bf47df708eb |
| issue_id | sr-ht-compare-d4m |
| event_type | created |
| actor | bigbes |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-18T00:37:45Z |
No comments.