main · last commit
6 hours ago ·
ti41arbu
sr-ht-dolt-mcy Honor SHA256SUM override in Makefile css recipe instead of hardcoded sha256sum
Lined Up
bd update sr-ht-dolt-mcy --claim
bd close sr-ht-dolt-mcy
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T20:38:57Z |
| Updated | 2026-08-17T20:38:57Z |
What is wrong: dolt's `Makefile` `css` recipe hardcodes `sha256sum` (`mv web/static/main.min.css web/static/main.min.$$(sha256sum … | cut -c1-8).css`). On a machine without GNU coreutils, `sha256sum` does not exist, the command substitution silently yields empty, and `mv` produces `web/static/main.min..css`. Why it matters: that filename does not match the `main.min.*.css` glob `assets.Resolve` looks for, so `assets.Resolve` answers `""` and every page renders unstyled — with no error anywhere (`set -e` does not catch a failure inside `$$( )`). This is compounded in dolt specifically by D23 (dolt does not log when the resolve comes back empty). Sibling that already does it correctly: `sourcehut-bench/Makefile` and `sourcehut-curator/Makefile` define `SHA256SUM ?= sha256sum` and use `$(SHA256SUM)`, with a comment naming `make SHA256SUM="shasum -a 256" css` as the macOS invocation. Fix: add `SHA256SUM ?= sha256sum` to dolt's Makefile and substitute `$(SHA256SUM)` in the `css` recipe. Status: verified (grep confirms dolt's Makefile has 0 uses of a `SHA256SUM` variable and ≥1 raw `sha256sum` call). Audit: D08 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | sr-ht-dolt-mcy |
| content_hash | 3da1b3c737bd8688221d30015d098ac8196252e83c5b2bf43c773cff7a0f1dbe |
| title | Honor SHA256SUM override in Makefile css recipe instead of hardcoded sha256sum |
| description | What is wrong: dolt's `Makefile` `css` recipe hardcodes `sha256sum` (`mv web/static/main.min.css web/static/main.min.$$(sha256sum … | cut -c1-8).css`). On a machine without GNU coreutils, `sha256sum` does not exist, the command substitution silently yields empty, and `mv` produces `web/static/main.min..css`. Why it matters: that filename does not match the `main.min.*.css` glob `assets.Resolve` looks for, so `assets.Resolve` answers `""` and every page renders unstyled — with no error anywhere (`set -e` does not catch a failure inside `$$( )`). This is compounded in dolt specifically by D23 (dolt does not log when the resolve comes back empty). Sibling that already does it correctly: `sourcehut-bench/Makefile` and `sourcehut-curator/Makefile` define `SHA256SUM ?= sha256sum` and use `$(SHA256SUM)`, with a comment naming `make SHA256SUM="shasum -a 256" css` as the macOS invocation. Fix: add `SHA256SUM ?= sha256sum` to dolt's Makefile and substitute `$(SHA256SUM)` in the `css` recipe. Status: verified (grep confirms dolt's Makefile has 0 uses of a `SHA256SUM` variable and ≥1 raw `sha256sum` call). Audit: D08 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 1 |
| issue_type | bug |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T20:38:57Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T20:38:57Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a01172-e339-72fd-9557-a1dcbdd8f626 |
| issue_id | sr-ht-dolt-mcy |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-17T23:38:57Z |
No comments.