main · last commit
6 hours ago ·
ti41arbu
sr-ht-dolt-s5e Fail CI (not skip) when *_TEST_PG is empty
Lined Up
bd update sr-ht-dolt-s5e --claim
bd close sr-ht-dolt-s5e
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T20:39:19Z |
| Updated | 2026-08-17T20:39:19Z |
What is wrong: dolt's `.build.yml` follows the family convention where a `<SVCPREFIX>_TEST_PG` env var names a real DSN and the test suite skips cleanly when it is unset. That is correct behavior for a developer laptop but wrong for CI: dolt's CI leaves the variable unset and the DB-backed tests are silently skipped rather than run. Why it matters: bench's own README documents the measured cost of this pattern elsewhere in the family — 4.5% versus 77.2% statement coverage in `db/` depending on whether the DB tests actually ran. A sibling's green CI in this configuration says nothing about its persistence layer, and `TestSchemaAndMigrationsAgree` (the test that keeps the fresh-install and upgrade paths from diverging) is exactly the kind of test this silently skips. Sibling that already does it correctly: `sourcehut-bench/.build.yml` brings up a Postgres inside the build VM, exports the DSN, and its `test` task refuses to run with the variable empty rather than skipping quietly. Fix: bring up Postgres in dolt's `.build.yml` (mirroring bench's approach) and make dolt's `test` task fail on an empty `*_TEST_PG` rather than skip. Status: reported (measurement quoted from bench's own README, not independently re-measured against dolt's coverage numbers for this register entry). Audit: D19 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | sr-ht-dolt-s5e |
| content_hash | 1a97ad25f8686aa211fbb6759f966e7d6545b1ee1bae2dc201f3abe9f4dc80d3 |
| title | Fail CI (not skip) when *_TEST_PG is empty |
| description | What is wrong: dolt's `.build.yml` follows the family convention where a `<SVCPREFIX>_TEST_PG` env var names a real DSN and the test suite skips cleanly when it is unset. That is correct behavior for a developer laptop but wrong for CI: dolt's CI leaves the variable unset and the DB-backed tests are silently skipped rather than run. Why it matters: bench's own README documents the measured cost of this pattern elsewhere in the family — 4.5% versus 77.2% statement coverage in `db/` depending on whether the DB tests actually ran. A sibling's green CI in this configuration says nothing about its persistence layer, and `TestSchemaAndMigrationsAgree` (the test that keeps the fresh-install and upgrade paths from diverging) is exactly the kind of test this silently skips. Sibling that already does it correctly: `sourcehut-bench/.build.yml` brings up a Postgres inside the build VM, exports the DSN, and its `test` task refuses to run with the variable empty rather than skipping quietly. Fix: bring up Postgres in dolt's `.build.yml` (mirroring bench's approach) and make dolt's `test` task fail on an empty `*_TEST_PG` rather than skip. Status: reported (measurement quoted from bench's own README, not independently re-measured against dolt's coverage numbers for this register entry). Audit: D19 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 2 |
| issue_type | task |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T20:39:19Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T20:39:19Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a01173-3837-77f3-9ea7-2bdaad45a489 |
| issue_id | sr-ht-dolt-s5e |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-17T23:39:18Z |
No comments.