main · last commit
5 hours ago ·
ti41arbu
sr-ht-dolt-tci mcpsrv: the get_commit_log cursor comment is now stale
Past Stand
bd reopen sr-ht-dolt-tci
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-08-13T06:35:06Z |
| Started | 2026-08-13T07:06:29Z |
| Updated | 2026-08-13T07:10:04Z |
| Closed | 2026-08-13T07:10:04Z |
mcpsrv/browse.go:527 says browse classifies an unparseable from-hash as a fault of its own "(it has no sentinel for it)", so a hand-written cursor takes the protocol arm. That stopped being true in 2c8903f: browse.Log now wraps it in ErrRefNotFound, and the call already routes through refMiss, so the behaviour is already right — only the comment is wrong. Fix the comment and add the test that pins the new behaviour (a garbage cursor is a tool-result miss, not an internal error).
A comment next to code is a claim, and this one now reads as a limitation the code no longer has.
No outgoing dependencies.
Nothing depends on this issue.
| id | sr-ht-dolt-tci |
| content_hash | a5b3bd37012658f7317a5085993430f2a209f6a80b8ae8811962d6e3cfd71ba4 |
| title | mcpsrv: the get_commit_log cursor comment is now stale |
| description | mcpsrv/browse.go:527 says browse classifies an unparseable from-hash as a fault of its own "(it has no sentinel for it)", so a hand-written cursor takes the protocol arm. That stopped being true in 2c8903f: browse.Log now wraps it in ErrRefNotFound, and the call already routes through refMiss, so the behaviour is already right — only the comment is wrong. Fix the comment and add the test that pins the new behaviour (a garbage cursor is a tool-result miss, not an internal error). |
| design | A comment next to code is a claim, and this one now reads as a limitation the code no longer has. |
| acceptance_criteria | |
| notes | |
| status | closed |
| priority | 3 |
| issue_type | task |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-13T06:35:06Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-13T07:10:04Z |
| closed_at | 2026-08-13T07:10:04Z |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | Landed in cdb9195. The agent also found the mcpsrv fake itself was wrong — its Log returned an unwrapped error for a bad cursor, i.e. it reproduced the very bug the stale comment described, so the comment fix alone would not have made the new test pass. |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | 2026-08-13T07:06:29Z |
| is_blocked | 0 |
| id | 019ff9d4-e311-72ee-bf9a-99b01cc740da |
| issue_id | sr-ht-dolt-tci |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-13T09:35:06Z |
| id | 019ff9f1-9ba7-7947-8427-e9e40287a0f3 |
| issue_id | sr-ht-dolt-tci |
| event_type | status_changed |
| actor | Eugene Blikh |
| old_value | {"id":"sr-ht-dolt-tci","title":"mcpsrv: the get_commit_log cursor comment is now stale","description":"mcpsrv/browse.go:527 says browse classifies an unparseable from-hash as a fault of its own \"(it has no sentinel for it)\", so a hand-written cursor takes the protocol arm. That stopped being true in 2c8903f: browse.Log now wraps it in ErrRefNotFound, and the call already routes through refMiss, so the behaviour is already right — only the comment is wrong. Fix the comment and add the test that pins the new behaviour (a garbage cursor is a tool-result miss, not an internal error).","design":"A comment next to code is a claim, and this one now reads as a limitation the code no longer has.","status":"open","priority":3,"issue_type":"task","owner":"bigbes@gmail.com","created_at":"2026-08-13T06:35:06Z","created_by":"Eugene Blikh","updated_at":"2026-08-13T06:35:06Z"} |
| new_value | {"status":"in_progress"} |
| comment | NULL |
| created_at | 2026-08-13T10:06:28Z |
| id | 019ff9f4-e471-762a-9a10-c456a6529b98 |
| issue_id | sr-ht-dolt-tci |
| event_type | closed |
| actor | Eugene Blikh |
| old_value | |
| new_value | Landed in cdb9195. The agent also found the mcpsrv fake itself was wrong — its Log returned an unwrapped error for a bad cursor, i.e. it reproduced the very bug the stale comment described, so the comment fix alone would not have made the new test pass. |
| comment | NULL |
| created_at | 2026-08-13T10:10:03Z |
No comments.
Close reason