main · last commit
10 hours ago ·
ti41arbu
sr-ht-dolt-zoe Switch template embed directive from glob patterns to all:templates
Lined Up
bd update sr-ht-dolt-zoe --claim
bd close sr-ht-dolt-zoe
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T20:40:01Z |
| Updated | 2026-08-17T20:40:01Z |
What is wrong: dolt's `//go:embed` directive for its template tree uses glob patterns (`templates/*.html templates/icons/*.svg` — dolt already needs a second pattern just to cover `icons/`) instead of the family's `all:templates` idiom used elsewhere. Both forms currently include `_`-prefixed partials in dolt's case (a glob is not subject to the directory-walk exclusion the `all:` prefix applies), so nothing is broken today. Why it matters: the glob form is the fragile one going forward — a partial added in a new subdirectory, or a `.svg`/`.txt` fragment outside the patterns already listed, is silently not embedded and fails only at request time as "no such template". This is a correctness risk on the next partial dolt adds, not just a style inconsistency. Sibling that already does it correctly: `all:templates` in artifacts, bench, coverage, curator, and tokens, each with a comment noting the `all:` prefix is load-bearing. Fix: switch dolt's embed directive from `templates/*.html templates/icons/*.svg` to `all:templates`. Status: verified. Audit: D39 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | sr-ht-dolt-zoe |
| content_hash | f46238392ff456bb6bf38845287fd7526a4f350e8cdc26fde35750ef2408893d |
| title | Switch template embed directive from glob patterns to all:templates |
| description | What is wrong: dolt's `//go:embed` directive for its template tree uses glob patterns (`templates/*.html templates/icons/*.svg` — dolt already needs a second pattern just to cover `icons/`) instead of the family's `all:templates` idiom used elsewhere. Both forms currently include `_`-prefixed partials in dolt's case (a glob is not subject to the directory-walk exclusion the `all:` prefix applies), so nothing is broken today. Why it matters: the glob form is the fragile one going forward — a partial added in a new subdirectory, or a `.svg`/`.txt` fragment outside the patterns already listed, is silently not embedded and fails only at request time as "no such template". This is a correctness risk on the next partial dolt adds, not just a style inconsistency. Sibling that already does it correctly: `all:templates` in artifacts, bench, coverage, curator, and tokens, each with a comment noting the `all:` prefix is load-bearing. Fix: switch dolt's embed directive from `templates/*.html templates/icons/*.svg` to `all:templates`. Status: verified. Audit: D39 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 3 |
| issue_type | task |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T20:40:01Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T20:40:01Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a01173-db0c-7353-8c52-8d4dc125332e |
| issue_id | sr-ht-dolt-zoe |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-17T23:40:00Z |
No comments.