main · last commit
18 hours ago ·
7bghjra2
sr-ht-ecore-uwy Fix bearer.Validate's doc example: it uses dolt's deliberately-absent write grant dolt:push
Lined Up
bd update sr-ht-ecore-uwy --claim
bd close sr-ht-ecore-uwy
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T20:38:11Z |
| Updated | 2026-08-17T20:38:11Z |
What is wrong: sr-ht-ecore/bearer/bearer.go::(*Validator).Validate's doc-comment example calls v.Validate(ctx, presented, "dolt:push"). dolt defines exactly one grant, core/grants.go::GrantRead = "dolt:read", and dolt's own grants.go deliberately refuses to define a write grant, with the comment 'a grant nobody checks is a promise to an operator that no code keeps'. ecore's doc example teaches the one grant string dolt made a considered decision not to have. Why it matters: this is exactly the kind of comment a donor copy would propagate verbatim — a future service author reading bearer's doc comment for the canonical usage example copies a grant string that directly contradicts a sibling's own documented design decision. Correct variant: sourcehut-dolt/core/grants.go (the source of truth for why dolt has no write grant). Fix: change the doc example to a grant string that actually exists, or use a clearly generic placeholder such as "svc:action" instead of a real service's grant name. Confidence: verified (dolt:push appears only in ecore's doc comment across the family; dolt:read is dolt's only constant). Audit: D48 item 3 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | sr-ht-ecore-uwy |
| content_hash | 1c67b32f754b883546be9494b605b0fc7573651f3012bceceb7c9d0ceb48d32a |
| title | Fix bearer.Validate's doc example: it uses dolt's deliberately-absent write grant dolt:push |
| description | What is wrong: sr-ht-ecore/bearer/bearer.go::(*Validator).Validate's doc-comment example calls v.Validate(ctx, presented, "dolt:push"). dolt defines exactly one grant, core/grants.go::GrantRead = "dolt:read", and dolt's own grants.go deliberately refuses to define a write grant, with the comment 'a grant nobody checks is a promise to an operator that no code keeps'. ecore's doc example teaches the one grant string dolt made a considered decision not to have. Why it matters: this is exactly the kind of comment a donor copy would propagate verbatim — a future service author reading bearer's doc comment for the canonical usage example copies a grant string that directly contradicts a sibling's own documented design decision. Correct variant: sourcehut-dolt/core/grants.go (the source of truth for why dolt has no write grant). Fix: change the doc example to a grant string that actually exists, or use a clearly generic placeholder such as "svc:action" instead of a real service's grant name. Confidence: verified (dolt:push appears only in ecore's doc comment across the family; dolt:read is dolt's only constant). Audit: D48 item 3 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 3 |
| issue_type | task |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T20:38:11Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T20:38:11Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a01172-30e4-7134-898b-490a4e0b5ff6 |
| issue_id | sr-ht-ecore-uwy |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-17T23:38:11Z |
No comments.