main · last commit
18 hours ago ·
8tmadfpi
spec-4eh Add check-version and check-embedded-css targets to specs' Makefile
Lined Up
bd update spec-4eh --claim
bd close spec-4eh
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T20:40:06Z |
| Updated | 2026-08-17T20:40:06Z |
What is wrong: specs' `Makefile` defines no `check-version:` or `check-embedded-css:` target, so its APKBUILD's `build()` runs only `make check-css` and `package()` re-verifies nothing. Why it matters: `check-version` inspects the compiled binary (`go version -m $(CHECK_BIN)`) for `vcs.revision`/`vcs.modified` and fails the build if the tree was dirty; `check-embedded-css` greps the binary for the embedded stylesheet name and diffs it against what is on disk, catching "compiled before `make css` ran". Without these, a dirty/unstamped binary "links, starts and serves" and only ever misreports itself — the family has hit this class for real (a `GOTMPDIR` race in federation, a `go mod download all` incident in bench), and the sha256sum Makefile bug (tracked separately, D08) makes specs hit the CSS half of this on any non-GNU machine with nothing catching it. Sibling that does it correctly: `sourcehut-bench`, `sourcehut-coverage`, `sourcehut-curator`, `sourcehut-tokens` (both targets) and `sourcehut-federation` (`check-version` only) all call these from both `build()` and `package()`, so the gate runs against the artefact that actually ships. Fix: port `check-version`/`check-embedded-css` plus their `CHECK_BIN`/`CHECK_BINS` staged-artefact invocations from `sourcehut-tokens/Makefile` into specs' `Makefile`, and wire both into the APKBUILD's `build()` and `package()`. Templating work, not new design. Note: confidence verified — `grep -n '^check-version:'` matches nothing in specs' Makefile. Audit: D12 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | spec-4eh |
| content_hash | 021baf11dcd3b18d6b17dd6b300612d9814525fef35c9aa29d1a938832b93835 |
| title | Add check-version and check-embedded-css targets to specs' Makefile |
| description | What is wrong: specs' `Makefile` defines no `check-version:` or `check-embedded-css:` target, so its APKBUILD's `build()` runs only `make check-css` and `package()` re-verifies nothing. Why it matters: `check-version` inspects the compiled binary (`go version -m $(CHECK_BIN)`) for `vcs.revision`/`vcs.modified` and fails the build if the tree was dirty; `check-embedded-css` greps the binary for the embedded stylesheet name and diffs it against what is on disk, catching "compiled before `make css` ran". Without these, a dirty/unstamped binary "links, starts and serves" and only ever misreports itself — the family has hit this class for real (a `GOTMPDIR` race in federation, a `go mod download all` incident in bench), and the sha256sum Makefile bug (tracked separately, D08) makes specs hit the CSS half of this on any non-GNU machine with nothing catching it. Sibling that does it correctly: `sourcehut-bench`, `sourcehut-coverage`, `sourcehut-curator`, `sourcehut-tokens` (both targets) and `sourcehut-federation` (`check-version` only) all call these from both `build()` and `package()`, so the gate runs against the artefact that actually ships. Fix: port `check-version`/`check-embedded-css` plus their `CHECK_BIN`/`CHECK_BINS` staged-artefact invocations from `sourcehut-tokens/Makefile` into specs' `Makefile`, and wire both into the APKBUILD's `build()` and `package()`. Templating work, not new design. Note: confidence verified — `grep -n '^check-version:'` matches nothing in specs' Makefile. Audit: D12 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 2 |
| issue_type | task |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T20:40:06Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T20:40:06Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a01173-f127-725d-8faa-46397b29194b |
| issue_id | spec-4eh |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-17T23:40:06Z |
No comments.