main · last commit
19 hours ago ·
8tmadfpi
spec-6cp Switch specs' go:embed templates directive to the all: prefix form
Lined Up
bd update spec-6cp --claim
bd close spec-6cp
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-08-17T20:40:11Z |
| Updated | 2026-08-17T20:40:11Z |
What is wrong: specs' `//go:embed` directive for the template tree uses a plain glob (`templates/*.html`) instead of the `all:` prefix form. Why it matters: nothing is broken today because there are no `_`-prefixed partials yet — a glob is not subject to Go's directory-walk underscore-exclusion, so it happens to include everything currently present. But the glob form is the fragile one: a partial added later in a subdirectory, or a non-`.html` fragment, is silently not embedded and fails at request time as "no such template" — dolt already needed a second pattern for its `icons/` directory because of exactly this. Sibling that does it correctly: `all:templates` in `sourcehut-artifacts`, `sourcehut-bench`, `sourcehut-coverage`, `sourcehut-curator`, `sourcehut-tokens`, each with a comment noting the `all:` prefix is load-bearing. Fix: switch specs' `//go:embed` directive to `//go:embed all:templates`. Audit: D39 (cross-repo audit, 2026-08-17)
No outgoing dependencies.
Nothing depends on this issue.
| id | spec-6cp |
| content_hash | ed6c4cb9fa18a51e051b9a9f0d1b85b5eb0e75f7797cb0cf94452c89dff5e63d |
| title | Switch specs' go:embed templates directive to the all: prefix form |
| description | What is wrong: specs' `//go:embed` directive for the template tree uses a plain glob (`templates/*.html`) instead of the `all:` prefix form. Why it matters: nothing is broken today because there are no `_`-prefixed partials yet — a glob is not subject to Go's directory-walk underscore-exclusion, so it happens to include everything currently present. But the glob form is the fragile one: a partial added later in a subdirectory, or a non-`.html` fragment, is silently not embedded and fails at request time as "no such template" — dolt already needed a second pattern for its `icons/` directory because of exactly this. Sibling that does it correctly: `all:templates` in `sourcehut-artifacts`, `sourcehut-bench`, `sourcehut-coverage`, `sourcehut-curator`, `sourcehut-tokens`, each with a comment noting the `all:` prefix is load-bearing. Fix: switch specs' `//go:embed` directive to `//go:embed all:templates`. Audit: D39 (cross-repo audit, 2026-08-17) |
| design | |
| acceptance_criteria | |
| notes | |
| status | open |
| priority | 3 |
| issue_type | task |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-08-17T20:40:11Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-08-17T20:40:11Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | �{} |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| id | 01a01174-0501-76e1-becb-0d97b6f997e5 |
| issue_id | spec-6cp |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-08-17T23:40:11Z |
No comments.