~bigbes/sr-ht-spec · parade

main · last commit 18 hours ago · 8tmadfpi

← Back to the parade

spec-by6.3.2 service: comment API + policy auto-merge gate Past Stand

status: closed P2 task @Eugene Blikh
bd reopen spec-by6.3.2
Created byEugene Blikh
Ownerbigbes@gmail.com
Created2026-07-24T18:57:05Z
Started2026-07-24T19:09:52Z
Updated2026-07-24T19:15:24Z
Closed2026-07-24T19:15:24Z
Description
service.Comment type, Comment/ListComments/ReplyComment/ResolveComment, and the anchor resolution pass that takes a revision's prosediff blocks and reports each comment as anchored, moved or outdated. Wire the merge gate: an unresolved comment suppresses policy auto-merge (not manual approve) — the check belongs beside the existing auto-merge policy evaluation, and needs a test that a commented proposal stops auto-merging while Merge with human approval still succeeds.

Depends on

  • spec-by6.3 — Phase 5b: inline comments on proposals parent-child closed
  • spec-by6.3.1 — Comment anchors: core type + db schema blocks closed

Depended on by

  • spec-by6.3.4 — mcpsrv: spec_comment tool (read + reply, no resolve) blocks
  • spec-by6.3.3 — web: commentable diff — context blocks, anchor ids, comment UI blocks

Prerequisite chain — everything this waits on, transitively

  • spec-by6.3 — Phase 5b: inline comments on proposals parent-child closed
  • spec-by6 — Phase 5: comments, webhooks, mutations, vector search parent-child open
  • spec-3vz — Phase 4: review plane — approve/reject in a browser blocks closed
  • spec-ejq — spec.sr.ht — reviewable document storage for humans and agents parent-child open
  • spec-zqb — Phase 3: write plane — agents propose blocks closed
  • spec-by6.3.1 — Comment anchors: core type + db schema blocks closed

No comments.

Close reason

service.CommentOn/ReplyTo/ResolveThread/Threads + AnchorThreads/AnchorOf; auto-merge gate in autoMerges. 10 tests, PG-backed ones green against real PG 16.
  • Eugene Blikh added under epic spec-by6.3 · 2026-07-24T21:57:05Z
  • Eugene Blikh created the issue · 2026-07-24T21:57:05Z
  • Eugene Blikh added dependency on spec-by6.3.1 · 2026-07-24T21:57:28Z
  • Eugene Blikh spec-by6.3.3 now depends on this · 2026-07-24T21:57:29Z
  • Eugene Blikh spec-by6.3.4 now depends on this · 2026-07-24T21:57:30Z
  • Eugene Blikh claimed · 2026-07-24T22:09:51Z
  • Eugene Blikh closed the issue · 2026-07-24T22:15:24Z
    service.CommentOn/ReplyTo/ResolveThread/Threads + AnchorThreads/AnchorOf; auto-merge gate in autoMerges. 10 tests, PG-backed ones green against real PG 16.
Stored rows — what this pane was built from, as read
issues 1 row
id spec-by6.3.2
content_hash f41b2b8f032a32187a1792e2db6d3fa537d5f5bf5e429b604c36c114ff708846
title service: comment API + policy auto-merge gate
description service.Comment type, Comment/ListComments/ReplyComment/ResolveComment, and the anchor resolution pass that takes a revision's prosediff blocks and reports each comment as anchored, moved or outdated. Wire the merge gate: an unresolved comment suppresses policy auto-merge (not manual approve) — the check belongs beside the existing auto-merge policy evaluation, and needs a test that a commented proposal stops auto-merging while Merge with human approval still succeeds.
design
acceptance_criteria
notes
status closed
priority 2
issue_type task
assignee Eugene Blikh
estimated_minutes NULL
created_at 2026-07-24T18:57:05Z
created_by Eugene Blikh
owner bigbes@gmail.com
updated_at 2026-07-24T19:15:24Z
closed_at 2026-07-24T19:15:24Z
closed_by_session
external_ref NULL
spec_id
compaction_level 0
compacted_at NULL
compacted_at_commit NULL
original_size NULL
sender
ephemeral 0
wisp_type
pinned 0
is_template 0
mol_type
work_type
source_system
metadata �{}
source_repo
close_reason service.CommentOn/ReplyTo/ResolveThread/Threads + AnchorThreads/AnchorOf; auto-merge gate in autoMerges. 10 tests, PG-backed ones green against real PG 16.
event_kind
actor
target
payload
await_type
await_id
timeout_ns 0
waiters
hook_bead
role_bead
agent_state
last_activity NULL
role_type
rig
due_at NULL
defer_until NULL
no_history 0
started_at 2026-07-24T19:09:52Z
is_blocked 0
dependencies 4 rows
id 0bcd2cb8-91ff-5495-af9b-118d58218cb0
issue_id spec-by6.3.4
type blocks
created_at 2026-07-24T21:57:30Z
created_by Eugene Blikh
metadata �{}
thread_id
depends_on_issue_id spec-by6.3.2
depends_on_wisp_id NULL
depends_on_external NULL
id 19dd6316-1c8f-53e8-848b-a0d99e483773
issue_id spec-by6.3.3
type blocks
created_at 2026-07-24T21:57:29Z
created_by Eugene Blikh
metadata �{}
thread_id
depends_on_issue_id spec-by6.3.2
depends_on_wisp_id NULL
depends_on_external NULL
id 5207f602-ab28-5e4c-82ba-c85ccb3b64c6
issue_id spec-by6.3.2
type parent-child
created_at 2026-07-24T21:57:05Z
created_by Eugene Blikh
metadata �{}
thread_id
depends_on_issue_id spec-by6.3
depends_on_wisp_id NULL
depends_on_external NULL
id d9befa05-1ff9-5d22-a31b-56610300cd06
issue_id spec-by6.3.2
type blocks
created_at 2026-07-24T21:57:28Z
created_by Eugene Blikh
metadata �{}
thread_id
depends_on_issue_id spec-by6.3.1
depends_on_wisp_id NULL
depends_on_external NULL
events 3 rows
id 019f957d-0092-706d-8434-6d4b8d36f36d
issue_id spec-by6.3.2
event_type created
actor Eugene Blikh
old_value
new_value
comment NULL
created_at 2026-07-24T21:57:05Z
id 019f9588-b33f-76e5-8c66-bf96dea4c4bc
issue_id spec-by6.3.2
event_type claimed
actor Eugene Blikh
old_value {"id":"spec-by6.3.2","title":"service: comment API + policy auto-merge gate","description":"service.Comment type, Comment/ListComments/ReplyComment/ResolveComment, and the anchor resolution pass that takes a revision's prosediff blocks and reports each comment as anchored, moved or outdated. Wire the merge gate: an unresolved comment suppresses policy auto-merge (not manual approve) — the check belongs beside the existing auto-merge policy evaluation, and needs a test that a commented proposal stops auto-merging while Merge with human approval still succeeds.","status":"open","priority":2,"issue_type":"task","owner":"bigbes@gmail.com","created_at":"2026-07-24T18:57:05Z","created_by":"Eugene Blikh","updated_at":"2026-07-24T18:57:05Z"}
new_value {"assignee":"Eugene Blikh","status":"in_progress"}
comment NULL
created_at 2026-07-24T22:09:51Z
id 019f958d-c531-794e-8a80-2f9e28a96f31
issue_id spec-by6.3.2
event_type closed
actor Eugene Blikh
old_value
new_value service.CommentOn/ReplyTo/ResolveThread/Threads + AnchorThreads/AnchorOf; auto-merge gate in autoMerges. 10 tests, PG-backed ones green against real PG 16.
comment NULL
created_at 2026-07-24T22:15:24Z