spec-wcr Loose ends from Phases 1-2 (latent bugs, no user impact yet) Past Stand

Real issues agents flagged and deliberately left alone during the parallel build. None blocks anything today; each is a trap for a later phase.

1. ProposalBranch derived THREE ways: core.ProposalBranch (canonical), and a third copy in SQL — db.OpenProposal concatenates prefix||serial in its INSERT to allocate id+branch atomically. Shares the prefix constant but not the function; reconcile if they can ever diverge. 2. doc.linkHierarchy passes path.Dir(p.Path) i.e. '.' as fromDir where every other call site uses DirOf ('') — section-proximity lookup misses for root-level parent: targets. Latent; fixing changes resolution behaviour. 3. doc.SplitLog collides entry IDs within a space (two type:log docs -> identical IDs -> second silently overwrites first in one index). Defended in search/ but should be fixed at source in doc/. 4. doc.Scan/DocumentSource are production-dead after service.Archive landed — they're the documented seam but also the API that made web's layering violation writable; delete is a judgement call. 5. mcpsrv ships a beforeCAS test hook in production code (gitx too). 6. No GraphQL complexity limit — service authenticates on its own router, not core-go's WithSchema, so nothing bounds query cost; low risk on a single-user authed surface. 7. Attachments: gitx walks .md only, so image embeds render as visibly-missing; needs WalkBlobs + asset index, or prefer Mermaid by convention.

RESOLVED 2026-07-24. All 7 items dispositioned.

#1 ProposalBranch 3rd copy in OpenProposal SQL — FIXED (e97532c), guard test.

#2 linkHierarchy path.Dir vs DirOf — FIXED. Prior triage called this a
judgement call that 'changes resolution behaviour'; that was wrong. Traced it:
path.Dir and DirOf differ only for root-level documents, and there the
section-proximity step (stemsIn[topSection(fromDir)+'/'+bare]) is subsumed by
the same-directory step above it — stemsIn['/x'] is populated only by a root
x.md, which byPath['x.md'] already returned. So '.' only ever skipped a lookup
that had already answered. VERIFIED by reverting to path.Dir and re-running:
identical results. Changed to DirOf as trap-removal, with
TestParentResolvesLikeAWikilinkFromTheSameDocument pinning the invariant
(parent: resolves to what the same wikilink in the body resolves to).

#3 SplitLog id collision — WONTFIX. Already correctly defended in
search/extract.go; 'fixing at source' would push index-keyspace uniqueness into
doc/, which shouldn't know it is indexed into a shared space index.

#4 delete doc.Scan/DocumentSource — DONE. Confirmed production-dead (only
consumer was doc's own test fixture). Deleted both; doc/ now owns no way to read
a revision, leaving service.Archive as the single route from rev to Archive —
closing the seam that made web's layering violation writable. doc test fixture
rewritten onto ListDocuments+FromDocuments; TestScanReportsGitErrors relocated
to gitx as TestWalkOfAnUnknownRevisionFails (gitx had no unknown-rev coverage).

#5 beforeCAS test hook — WONTFIX. Unexported, set only by same-package tests,
cannot be set externally. Standard test-seam pattern; mcpsrv has no such hook.

#6 GraphQL complexity limit — moved to spec-by6.1 (feature, Phase 5).
#7 attachments — moved to spec-by6.2 (feature, Phase 5).