99ucjldio6vte0p8jj4p5e46svrj43nl · 118 rows
| id | issue_id | event_type | actor | old_value | new_value | comment | created_at |
|---|---|---|---|---|---|---|---|
| 000fef98-f0eb-4c85-8118-79fdda5bff24 | tarantool-etcd-4y9 | created | Eugene Blikh | NULL | 2026-05-19T17:54:52Z | ||
| 01265226-b3bd-4381-866a-6dc7a85b54a1 | tarantool-etcd-8zm | created | Eugene Blikh | NULL | 2026-05-19T17:54:13Z | ||
| 02b3e265-33a8-4e1b-bf2b-f8ee8d47ba31 | tarantool-etcd-3sp | claimed | Eugene Blikh | {"id":"tarantool-etcd-3sp","title":"LeaseKeepAlive fsyncs WAL on every renew","description":"On btrfs SSD bench (2026-05-19 disk run), LeaseKeepAlive/n_X drops from 4 234 ops/s (tmpfs) to 207 ops/s on tarantool while etcd holds at ~7 400 ops/s in both configs.\n\np50 goes from 224 µs (tmpfs) to 4 548 µs (disk) — exactly one btrfs fsync. Root cause at app/etcd/lease.lua:191:\n\n box.space.leases:update(id, {{'=', 'expiry_time', now + lease.ttl}})\n\nThe leases space is is_sync=true so every keep-alive does a full WAL append + fsync. Etcd's KeepAlive is an in-memory TTL bump with no disk write.\n\nFix sketch: split expiry into an in-memory map (refreshed on every KeepAlive) and persist only on grant/revoke. The expiry fiber should read from the in-memory map. Trade-off: leases may extend further into the future than the on-disk record after a crash, which is fine — clients have to re-keep-alive after reconnect anyway.\n\nSee docs/BENCH.md Linux x86_64 disk section (Open follow-ups).","design":"GOAL: lease keep-alive must not touch the WAL. Mirror etcd's split — durable\nstate = {lease record, granted TTL, attached keys}; ephemeral leader-local\nstate = the expiry deadline (refreshed on every keep-alive, never persisted).\n\n=== STATE MODEL ===\nAdd a module-level in-memory map in app/etcd/lease.lua:\n local deadlines = {} -- [lease_id] = monotonic deadline (clock.monotonic()+ttl)\nThis is leader-local. Followers never keep-alive (the gRPC write gate routes\nLeaseKeepAlive to the leader), and only the leader runs the expiry fiber and\ncan revoke. So the countdown is structurally a leader concern.\n\nThe `leases` space (schema.lua:97-118) stays is_sync=true and keeps its\n{id, ttl, expiry_time, granted_ttl} format. The `expiry_time` FIELD and its\nTREE index (schema.lua:113) become vestigial — written once at grant, never\nthe source of liveness again. Leave them to avoid a space migration; an\noptional follow-up can drop the field+index. Nothing reads expiry_time after\nthis change.\n\n=== HANDLER CHANGES (app/etcd/lease.lua) ===\n1. grant() ~L70: after `box.space.leases:insert(...)`, seed\n `deadlines[id] = now + ttl`. Insert still persists (durable, required).\n2. keepalive() ~L191: REPLACE\n box.space.leases:update(id, {{'=', 'expiry_time', now + lease.ttl}})\n with\n deadlines[id] = clock.monotonic() + lease.ttl\n Keep the `box.space.leases:get(id)` existence check above it (cheap read,\n no fsync) — it supplies lease.ttl and preserves the NOT_FOUND-raises\n contract the gRPC stream handler depends on (see L169-171).\n3. revoke() ~L150: after `box.space.leases:delete(id)`, clear\n `deadlines[id] = nil`.\n4. time_to_live() ~L236: REPLACE `lease.expiry_time` read with `deadlines[id]`.\n If deadlines[id] is nil (lease loaded but not yet rebuilt), fall back to\n `clock.monotonic() + lease.granted_ttl`. remaining = max(0, floor(dl - now)).\n5. expiry_loop() L287-338: REPLACE the `box.space.leases.index.expiry_time`\n scan (L302-309) with a scan of `deadlines`: collect ids where\n `deadline \u003c= now`. Plain full-table scan is fine (numeric compares in Lua,\n runs every 500ms); a min-heap (etcd's leaseExpiredNotifier shape) is the\n optional optimization if lease counts get large. revoke() already nils the\n map entry on success.\n\n=== REBUILD ON PROMOTE ===\nAdd lease.M.rebuild_deadlines():\n clears `deadlines`, then for each tuple in box.space.leases:pairs() sets\n deadlines[tuple.id] = clock.monotonic() + tuple.ttl\nCall it in the RW branch of the box.watch('box.status', ...) callback in\napp/roles/etcd.lua (L341-353), immediately before lease.start_expiry().\nThis resets every inherited lease's deadline to a full-TTL grace period on the\nnew leader — exactly etcd's failover behavior.\n\n=== LATENT BUG THIS ALSO FIXES ===\nexpiry_time is currently computed as clock.monotonic()+ttl and REPLICATED.\nclock.monotonic() is process-local (relative to boot), so the persisted value\nis meaningless on any other node. Today a promoted replica's fiber scans\ninherited expiry_time values from a different monotonic timeline — could\nexpire leases instantly or never. Rebuild-on-promote with the new leader's own\nclock removes this entirely.","acceptance_criteria":"- keepalive issues ZERO WAL writes: box.info.lsn delta == 0 across N successive\n M.keepalive() calls on the same lease.\n- BenchmarkLeaseKeepAlive/n_* on btrfs SSD (work.lab.local, real-disk run)\n recovers from 207 ops/s to within ~2x of etcd (~4000+ ops/s, near the tmpfs\n baseline). Re-run: TMPDIR=$HOME/bench-data go test -run=^$ \\\n -bench=^BenchmarkLeaseKeepAlive$ -benchtime=5s ./bench/\n- Lease still expires correctly: grant short TTL, no keep-alive, attached keys\n are deleted by the fiber after TTL elapses; keep-alive before TTL prevents it.\n- TimeToLive reflects the latest keep-alive (remaining resets to ~ttl after a\n renew).\n- Promote rebuilds deadlines: a freshly-promoted leader expires inherited\n leases using its own monotonic clock (no instant-expiry, no never-expiry).\n- All existing lease conformance cells (tarantool, tarantool_json,\n tarantool_rs3) and Lua lease tests pass.","notes":"TESTS (add Lua-side tests pinning the fix per the project's regression rule):\n- no-WAL: assert box.info.lsn unchanged across keepalive calls.\n- liveness: keepalive refreshes deadline (TimeToLive resets, lease survives).\n- promote rebuild: use the box.cfg{read_only=true}...{read_only=false}+\n box.ctl.promote() in-process follower-simulation pattern (see role_test.lua\n group role/write_gates_in_process) to verify rebuild_deadlines repopulates.\n- cross-node: optionally exercise via the replicaset harness that a promoted\n replica expires an inherited lease.\nConformance already covers cross-wire correctness; this is about the Lua unit\npins + the bench recovery number.\n\nDOCS: update docs/BENCH.md Linux x86_64 disk section once re-benched; remove\nthe LeaseKeepAlive \"bug\" annotation from the headline table.\n\nSCOPE NOTE: leave the expiry_time field + index in place (no migration). Only\nthe keepalive write path and the fiber's liveness source change.","status":"open","priority":2,"issue_type":"bug","owner":"bigbes@gmail.com","created_at":"2026-05-19T17:33:47Z","created_by":"Eugene Blikh","updated_at":"2026-05-20T04:39:23Z"} | {"assignee":"Eugene Blikh","status":"in_progress"} | NULL | 2026-05-20T15:46:48Z |
| 033a914b-1f3e-4bdb-9553-a81981f72943 | tarantool-etcd-00h | created | Eugene Blikh | NULL | 2026-05-20T09:55:25Z | ||
| 037ee7a8-6029-4854-bf3b-af0456dd52e7 | tarantool-etcd-3sp | closed | Eugene Blikh | keep-alive now bumps a leader-local in-memory deadline map (zero WAL on renew); leases space written only on grant/revoke; rebuild_deadlines on promote. Lua regression tests + TestLease conformance pass. Disk re-bench on btrfs SSD still pending to replace pre-fix BENCH.md numbers. | NULL | 2026-05-20T15:53:33Z | |
| 054042b2-efb1-4780-906f-ea6461c2bbe0 | tarantool-etcd-5zx | created | Eugene Blikh | NULL | 2026-05-19T17:54:36Z | ||
| 0664fe02-5b7b-4bfe-a708-5db2886620ef | tarantool-etcd-mo5 | created | Eugene Blikh | NULL | 2026-05-19T17:54:26Z | ||
| 07d96215-4a88-46f5-b1c9-b30556edaec5 | tarantool-etcd-70j | created | Eugene Blikh | NULL | 2026-05-19T17:54:28Z | ||
| 0a9851f8-9f2e-4b02-9d0b-c718b271c28f | tarantool-etcd-1qa | created | Eugene Blikh | NULL | 2026-05-20T14:59:03Z | ||
| 0bc59661-158a-48bf-b22b-78f0adeefeb1 | tarantool-etcd-tt6 | created | Eugene Blikh | NULL | 2026-05-20T09:17:56Z | ||
| 0cb660ac-8609-49d6-979e-b78259436280 | tarantool-etcd-3c2 | created | Eugene Blikh | NULL | 2026-05-19T17:54:23Z | ||
| 0e0fb1ab-9762-4a05-8ccb-4fc6668a13bd | tarantool-etcd-boq | created | Eugene Blikh | NULL | 2026-05-20T09:45:15Z | ||
| 12ea9ddb-ef88-4b53-877b-f86778387cb6 | tarantool-etcd-3sp | updated | Eugene Blikh | {"id":"tarantool-etcd-3sp","title":"LeaseKeepAlive fsyncs WAL on every renew","description":"On btrfs SSD bench (2026-05-19 disk run), LeaseKeepAlive/n_X drops from 4 234 ops/s (tmpfs) to 207 ops/s on tarantool while etcd holds at ~7 400 ops/s in both configs.\n\np50 goes from 224 µs (tmpfs) to 4 548 µs (disk) — exactly one btrfs fsync. Root cause at app/etcd/lease.lua:191:\n\n box.space.leases:update(id, {{'=', 'expiry_time', now + lease.ttl}})\n\nThe leases space is is_sync=true so every keep-alive does a full WAL append + fsync. Etcd's KeepAlive is an in-memory TTL bump with no disk write.\n\nFix sketch: split expiry into an in-memory map (refreshed on every KeepAlive) and persist only on grant/revoke. The expiry fiber should read from the in-memory map. Trade-off: leases may extend further into the future than the on-disk record after a crash, which is fine — clients have to re-keep-alive after reconnect anyway.\n\nSee docs/BENCH.md Linux x86_64 disk section (Open follow-ups).","design":"GOAL: lease keep-alive must not touch the WAL. Mirror etcd's split — durable\nstate = {lease record, granted TTL, attached keys}; ephemeral leader-local\nstate = the expiry deadline (refreshed on every keep-alive, never persisted).\n\n=== STATE MODEL ===\nAdd a module-level in-memory map in app/etcd/lease.lua:\n local deadlines = {} -- [lease_id] = monotonic deadline (clock.monotonic()+ttl)\nThis is leader-local. Followers never keep-alive (the gRPC write gate routes\nLeaseKeepAlive to the leader), and only the leader runs the expiry fiber and\ncan revoke. So the countdown is structurally a leader concern.\n\nThe `leases` space (schema.lua:97-118) stays is_sync=true and keeps its\n{id, ttl, expiry_time, granted_ttl} format. The `expiry_time` FIELD and its\nTREE index (schema.lua:113) become vestigial — written once at grant, never\nthe source of liveness again. Leave them to avoid a space migration; an\noptional follow-up can drop the field+index. Nothing reads expiry_time after\nthis change.\n\n=== HANDLER CHANGES (app/etcd/lease.lua) ===\n1. grant() ~L70: after `box.space.leases:insert(...)`, seed\n `deadlines[id] = now + ttl`. Insert still persists (durable, required).\n2. keepalive() ~L191: REPLACE\n box.space.leases:update(id, {{'=', 'expiry_time', now + lease.ttl}})\n with\n deadlines[id] = clock.monotonic() + lease.ttl\n Keep the `box.space.leases:get(id)` existence check above it (cheap read,\n no fsync) — it supplies lease.ttl and preserves the NOT_FOUND-raises\n contract the gRPC stream handler depends on (see L169-171).\n3. revoke() ~L150: after `box.space.leases:delete(id)`, clear\n `deadlines[id] = nil`.\n4. time_to_live() ~L236: REPLACE `lease.expiry_time` read with `deadlines[id]`.\n If deadlines[id] is nil (lease loaded but not yet rebuilt), fall back to\n `clock.monotonic() + lease.granted_ttl`. remaining = max(0, floor(dl - now)).\n5. expiry_loop() L287-338: REPLACE the `box.space.leases.index.expiry_time`\n scan (L302-309) with a scan of `deadlines`: collect ids where\n `deadline \u003c= now`. Plain full-table scan is fine (numeric compares in Lua,\n runs every 500ms); a min-heap (etcd's leaseExpiredNotifier shape) is the\n optional optimization if lease counts get large. revoke() already nils the\n map entry on success.\n\n=== REBUILD ON PROMOTE ===\nAdd lease.M.rebuild_deadlines():\n clears `deadlines`, then for each tuple in box.space.leases:pairs() sets\n deadlines[tuple.id] = clock.monotonic() + tuple.ttl\nCall it in the RW branch of the box.watch('box.status', ...) callback in\napp/roles/etcd.lua (L341-353), immediately before lease.start_expiry().\nThis resets every inherited lease's deadline to a full-TTL grace period on the\nnew leader — exactly etcd's failover behavior.\n\n=== LATENT BUG THIS ALSO FIXES ===\nexpiry_time is currently computed as clock.monotonic()+ttl and REPLICATED.\nclock.monotonic() is process-local (relative to boot), so the persisted value\nis meaningless on any other node. Today a promoted replica's fiber scans\ninherited expiry_time values from a different monotonic timeline — could\nexpire leases instantly or never. Rebuild-on-promote with the new leader's own\nclock removes this entirely.","status":"open","priority":2,"issue_type":"bug","owner":"bigbes@gmail.com","created_at":"2026-05-19T17:33:47Z","created_by":"Eugene Blikh","updated_at":"2026-05-20T04:39:03Z"} | {"acceptance_criteria":"- keepalive issues ZERO WAL writes: box.info.lsn delta == 0 across N successive\n M.keepalive() calls on the same lease.\n- BenchmarkLeaseKeepAlive/n_* on btrfs SSD (work.lab.local, real-disk run)\n recovers from 207 ops/s to within ~2x of etcd (~4000+ ops/s, near the tmpfs\n baseline). Re-run: TMPDIR=$HOME/bench-data go test -run=^$ \\\n -bench=^BenchmarkLeaseKeepAlive$ -benchtime=5s ./bench/\n- Lease still expires correctly: grant short TTL, no keep-alive, attached keys\n are deleted by the fiber after TTL elapses; keep-alive before TTL prevents it.\n- TimeToLive reflects the latest keep-alive (remaining resets to ~ttl after a\n renew).\n- Promote rebuilds deadlines: a freshly-promoted leader expires inherited\n leases using its own monotonic clock (no instant-expiry, no never-expiry).\n- All existing lease conformance cells (tarantool, tarantool_json,\n tarantool_rs3) and Lua lease tests pass.","notes":"TESTS (add Lua-side tests pinning the fix per the project's regression rule):\n- no-WAL: assert box.info.lsn unchanged across keepalive calls.\n- liveness: keepalive refreshes deadline (TimeToLive resets, lease survives).\n- promote rebuild: use the box.cfg{read_only=true}...{read_only=false}+\n box.ctl.promote() in-process follower-simulation pattern (see role_test.lua\n group role/write_gates_in_process) to verify rebuild_deadlines repopulates.\n- cross-node: optionally exercise via the replicaset harness that a promoted\n replica expires an inherited lease.\nConformance already covers cross-wire correctness; this is about the Lua unit\npins + the bench recovery number.\n\nDOCS: update docs/BENCH.md Linux x86_64 disk section once re-benched; remove\nthe LeaseKeepAlive \"bug\" annotation from the headline table.\n\nSCOPE NOTE: leave the expiry_time field + index in place (no migration). Only\nthe keepalive write path and the fiber's liveness source change."} | NULL | 2026-05-20T07:39:22Z |
| 1632bb64-4a7b-4e1c-b45e-a87309d9a8db | tarantool-etcd-uee | created | Eugene Blikh | NULL | 2026-05-20T09:17:54Z | ||
| 18fe139b-df94-451a-8e87-a2ca72e657e0 | tarantool-etcd-ymm | created | Eugene Blikh | NULL | 2026-05-19T17:54:41Z | ||
| 1ce593c2-ac19-43ae-b8a2-3334751c95dd | tarantool-etcd-nwl | created | Eugene Blikh | NULL | 2026-05-19T17:54:11Z | ||
| 1d7bbef0-a625-4b7e-9459-5d59c8029828 | tarantool-etcd-w8q | created | Eugene Blikh | NULL | 2026-05-19T17:53:51Z | ||
| 1d8a485e-0bb1-4902-8690-ecd2e4d36a43 | tarantool-etcd-929 | created | Eugene Blikh | NULL | 2026-05-19T17:54:30Z | ||
| 1fa4e29e-2f25-4419-9818-77e0f4af47b2 | tarantool-etcd-9z2 | created | Eugene Blikh | NULL | 2026-05-19T16:34:06Z | ||
| 2921ede2-b70c-44f4-8e52-54255702370a | tarantool-etcd-dmt | created | Eugene Blikh | NULL | 2026-05-19T17:54:53Z | ||
| 2d2828f8-6cf0-4859-9db8-430ae1f7a9d7 | tarantool-etcd-g1a | created | Eugene Blikh | NULL | 2026-05-19T17:54:25Z | ||
| 2e9cfbea-e2f5-4e74-8f33-41ce4f2a9370 | tarantool-etcd-iz4 | created | Eugene Blikh | NULL | 2026-05-19T17:54:15Z | ||
| 323218d7-991c-4baa-9e61-32ec89198c10 | tarantool-etcd-7kb | created | Eugene Blikh | NULL | 2026-05-19T17:54:18Z | ||
| 353c3076-8b72-42ef-8fb5-ef1f700df311 | tarantool-etcd-ovt | created | Eugene Blikh | NULL | 2026-05-19T17:54:21Z | ||
| 35af2e9c-c033-4f03-8b56-efe92ec8b347 | tarantool-etcd-0uw | created | Eugene Blikh | NULL | 2026-05-19T17:53:54Z | ||
| 3690d19b-6bf7-4ee3-b57b-858ee5a8f937 | tarantool-etcd-3sp | created | Eugene Blikh | NULL | 2026-05-19T20:33:47Z | ||
| 36a3b9e9-2035-470e-ab66-3380d4d56902 | tarantool-etcd-0gv | created | Eugene Blikh | NULL | 2026-05-19T17:54:09Z | ||
| 375e6d39-4371-425a-8f33-74f31ce84392 | tarantool-etcd-cpp | created | Eugene Blikh | NULL | 2026-05-20T09:55:23Z | ||
| 39066b96-06b0-4e17-8050-a78a8b00be14 | tarantool-etcd-zws | created | Eugene Blikh | NULL | 2026-05-20T09:17:55Z | ||
| 3bae43c8-27f2-4820-8048-4a02a89a9d4d | tarantool-etcd-3co | created | Eugene Blikh | NULL | 2026-05-19T17:54:16Z | ||
| 3c8a8e00-bb58-4ade-b7b1-e19dd83a32e0 | tarantool-etcd-p3s | created | Eugene Blikh | NULL | 2026-05-19T17:54:48Z | ||
| 411558db-b3ff-4790-bc94-3f7d1eb411c4 | tarantool-etcd-j1c | created | Eugene Blikh | NULL | 2026-05-19T16:34:30Z | ||
| 42dd73d1-1e61-419b-9025-aacb3eaa915e | tarantool-etcd-h8r | created | Eugene Blikh | NULL | 2026-05-19T17:54:50Z | ||
| 430012bd-a6c5-41d6-96c2-81ec1646408d | tarantool-etcd-8t0 | created | Eugene Blikh | NULL | 2026-05-19T17:54:00Z | ||
| 436c1852-ceec-470b-a798-efd84bcdab75 | tarantool-etcd-40s | created | Eugene Blikh | NULL | 2026-05-19T17:54:01Z | ||
| 455cfe4d-7294-4c69-9323-3fddcdc09ee6 | tarantool-etcd-9cd | created | Eugene Blikh | NULL | 2026-05-19T17:53:58Z | ||
| 48efda0f-f28e-419d-85ac-3642a7629eb7 | tarantool-etcd-828 | created | Eugene Blikh | NULL | 2026-05-19T17:54:27Z | ||
| 4bac8298-81b3-41fe-b1de-2c987975ddff | tarantool-etcd-sdt | created | Eugene Blikh | NULL | 2026-05-19T17:54:04Z | ||
| 4e1fc57d-bc4b-4964-ba4e-902309c5ff88 | tarantool-etcd-6js | created | Eugene Blikh | NULL | 2026-05-20T09:45:15Z | ||
| 4ff89f00-22b0-42b0-91d5-662b40d6777d | tarantool-etcd-unw | created | Eugene Blikh | NULL | 2026-05-20T09:55:22Z | ||
| 53c75b20-b2f8-497e-a7af-57a5637ec9a8 | tarantool-etcd-6zn | created | Eugene Blikh | NULL | 2026-05-20T09:45:17Z | ||
| 571acc91-b6a6-4750-aeb2-c1b07177cb5a | tarantool-etcd-bg4 | created | Eugene Blikh | NULL | 2026-05-19T17:54:14Z | ||
| 57625cfc-bfcf-4d28-bee1-8d160230d03e | tarantool-etcd-bq8 | created | Eugene Blikh | NULL | 2026-05-19T17:53:59Z | ||
| 57a8f358-4b13-4ab0-b57c-033b3bc71f64 | tarantool-etcd-7ey | created | Eugene Blikh | NULL | 2026-05-20T08:48:14Z | ||
| 5867eb7d-94e2-44f6-a474-655d28d0c76f | tarantool-etcd-60x | created | Eugene Blikh | NULL | 2026-05-19T17:54:01Z | ||
| 5a3c40de-c488-45da-9203-ae6950c230ad | tarantool-etcd-0gn | created | Eugene Blikh | NULL | 2026-05-20T09:35:53Z | ||
| 5c543288-bce3-4a95-b66f-dd84b88ce45b | tarantool-etcd-8ss | claimed | Eugene Blikh | {"id":"tarantool-etcd-8ss","title":"Example 2: 3-node EE replicaset self-hosting its own etcd config (file → etcd migration)","description":"Add examples/tarantool-ee-self-hosted-etcd: boot a 3-instance EE replicaset (election failover) from a local cluster-config.yaml where every node runs app.roles.etcd (replicated KV store, read_pref=any). Seed the cluster's OWN etcd store with that config, then rolling-restart each instance to bootstrap from TT_CONFIG_ETCD_* (no --config). Document the cold-boot circularity: self-hosted etcd-config is HA under rolling restart but needs the local file retained as a cold-boot seed. Justfile + README + cluster-config.yaml.","status":"open","priority":2,"issue_type":"feature","owner":"bigbes@gmail.com","created_at":"2026-05-20T11:16:17Z","created_by":"Eugene Blikh","updated_at":"2026-05-20T11:16:17Z"} | {"assignee":"Eugene Blikh","status":"in_progress"} | NULL | 2026-05-20T14:16:28Z |
| 5e3d435c-1dc9-4bdd-a716-a8c79670316a | tarantool-etcd-zwg | created | Eugene Blikh | NULL | 2026-05-19T17:54:07Z | ||
| 60d04eed-2387-4f84-89a7-0ef5988c0385 | tarantool-etcd-rzs | created | Eugene Blikh | NULL | 2026-05-19T17:54:23Z | ||
| 61951fb7-6389-47f7-bb7c-f727d1698ac2 | tarantool-etcd-hco | created | Eugene Blikh | NULL | 2026-05-19T17:54:50Z |