~bigbes/tarantool-etcd · events

d7td0mgcv9aro8ppnkgknqnbn4saht8b · 87 rows

idissue_idevent_typeactorold_valuenew_valuecommentcreated_at
8d49ce84-20c5-4706-8147-6bd291eb742atarantool-etcd-6ljcreatedEugene BlikhNULL2026-05-19T17:53:56Z
8d9d43c2-3fde-477f-909e-6692642d0f7atarantool-etcd-wgxcreatedEugene BlikhNULL2026-05-19T17:54:05Z
91dd9f8a-46c8-4fa9-9990-b5ef64d21db8tarantool-etcd-0uscreatedEugene BlikhNULL2026-05-19T17:54:32Z
95dd1a81-ac4a-443e-9357-0231ae710df4tarantool-etcd-2alcreatedEugene BlikhNULL2026-05-19T17:54:10Z
9942c15d-10dd-4175-b258-d3eac38cbf68tarantool-etcd-sy6createdEugene BlikhNULL2026-05-19T17:53:56Z
999323d2-60cd-4dc1-a096-4e436ea35bc4tarantool-etcd-hx9createdEugene BlikhNULL2026-05-19T17:54:20Z
9d480c92-7d70-47cb-99dc-2aaaadf079adtarantool-etcd-cz5createdEugene BlikhNULL2026-05-19T17:54:41Z
a19c7caf-7c98-4289-86e0-3dd93b81e977tarantool-etcd-ag2createdEugene BlikhNULL2026-05-19T17:54:06Z
ad2500dc-5e99-4b7b-b828-7c7be8323f5btarantool-etcd-ak9createdEugene BlikhNULL2026-05-19T17:54:03Z
ae980e19-525b-489c-9824-5dddc5ed8dc9tarantool-etcd-2pacreatedEugene BlikhNULL2026-05-19T17:54:12Z
b16d8be3-aaad-4f74-b1c3-d62ddb2be376tarantool-etcd-50gcreatedEugene BlikhNULL2026-05-19T17:54:19Z
b6ab8af9-f3dc-48fe-b30c-223f9fe0fb59tarantool-etcd-w5rcreatedEugene BlikhNULL2026-05-19T17:54:43Z
ba878427-f6e7-40e5-a96f-0a41c5357472tarantool-etcd-m1ncreatedEugene BlikhNULL2026-05-19T17:54:47Z
c1386207-32df-49c3-b25c-ee876836ea2ftarantool-etcd-buqcreatedEugene BlikhNULL2026-05-19T16:34:52Z
c6b02065-1911-4de5-8c58-703f1b1692a0tarantool-etcd-acpcreatedEugene BlikhNULL2026-05-19T17:53:51Z
cb892177-bcbc-4882-91f0-1785edb94ff0tarantool-etcd-070createdEugene BlikhNULL2026-05-19T17:53:57Z
ccedcf22-e6e2-405a-8858-3f9736f1fa40tarantool-etcd-jg3createdEugene BlikhNULL2026-05-20T09:17:53Z
cec28fbf-5a6f-4db7-b464-7e342c8db297tarantool-etcd-75ucreatedEugene BlikhNULL2026-05-20T09:17:55Z
d03951d3-60b2-45c7-840f-7d0341f72993tarantool-etcd-wqncreatedEugene BlikhNULL2026-05-19T17:54:30Z
d2e53a79-8623-4b49-bb6e-49bbf78e2cectarantool-etcd-584createdEugene BlikhNULL2026-05-19T17:53:53Z
d6b47667-9634-4546-8b96-39a6728f21ddtarantool-etcd-b08createdEugene BlikhNULL2026-05-19T16:34:09Z
daf8dd2b-bb5f-4961-8464-27cd5bddd3f5tarantool-etcd-3spupdatedEugene Blikh{"id":"tarantool-etcd-3sp","title":"LeaseKeepAlive fsyncs WAL on every renew","description":"On btrfs SSD bench (2026-05-19 disk run), LeaseKeepAlive/n_X drops from 4 234 ops/s (tmpfs) to 207 ops/s on tarantool while etcd holds at ~7 400 ops/s in both configs.\n\np50 goes from 224 µs (tmpfs) to 4 548 µs (disk) — exactly one btrfs fsync. Root cause at app/etcd/lease.lua:191:\n\n box.space.leases:update(id, {{'=', 'expiry_time', now + lease.ttl}})\n\nThe leases space is is_sync=true so every keep-alive does a full WAL append + fsync. Etcd's KeepAlive is an in-memory TTL bump with no disk write.\n\nFix sketch: split expiry into an in-memory map (refreshed on every KeepAlive) and persist only on grant/revoke. The expiry fiber should read from the in-memory map. Trade-off: leases may extend further into the future than the on-disk record after a crash, which is fine — clients have to re-keep-alive after reconnect anyway.\n\nSee docs/BENCH.md Linux x86_64 disk section (Open follow-ups).","status":"open","priority":2,"issue_type":"bug","owner":"bigbes@gmail.com","created_at":"2026-05-19T17:33:47Z","created_by":"Eugene Blikh","updated_at":"2026-05-19T17:33:47Z"}{"design":"GOAL: lease keep-alive must not touch the WAL. Mirror etcd's split — durable\nstate = {lease record, granted TTL, attached keys}; ephemeral leader-local\nstate = the expiry deadline (refreshed on every keep-alive, never persisted).\n\n=== STATE MODEL ===\nAdd a module-level in-memory map in app/etcd/lease.lua:\n local deadlines = {} -- [lease_id] = monotonic deadline (clock.monotonic()+ttl)\nThis is leader-local. Followers never keep-alive (the gRPC write gate routes\nLeaseKeepAlive to the leader), and only the leader runs the expiry fiber and\ncan revoke. So the countdown is structurally a leader concern.\n\nThe `leases` space (schema.lua:97-118) stays is_sync=true and keeps its\n{id, ttl, expiry_time, granted_ttl} format. The `expiry_time` FIELD and its\nTREE index (schema.lua:113) become vestigial — written once at grant, never\nthe source of liveness again. Leave them to avoid a space migration; an\noptional follow-up can drop the field+index. Nothing reads expiry_time after\nthis change.\n\n=== HANDLER CHANGES (app/etcd/lease.lua) ===\n1. grant() ~L70: after `box.space.leases:insert(...)`, seed\n `deadlines[id] = now + ttl`. Insert still persists (durable, required).\n2. keepalive() ~L191: REPLACE\n box.space.leases:update(id, {{'=', 'expiry_time', now + lease.ttl}})\n with\n deadlines[id] = clock.monotonic() + lease.ttl\n Keep the `box.space.leases:get(id)` existence check above it (cheap read,\n no fsync) — it supplies lease.ttl and preserves the NOT_FOUND-raises\n contract the gRPC stream handler depends on (see L169-171).\n3. revoke() ~L150: after `box.space.leases:delete(id)`, clear\n `deadlines[id] = nil`.\n4. time_to_live() ~L236: REPLACE `lease.expiry_time` read with `deadlines[id]`.\n If deadlines[id] is nil (lease loaded but not yet rebuilt), fall back to\n `clock.monotonic() + lease.granted_ttl`. remaining = max(0, floor(dl - now)).\n5. expiry_loop() L287-338: REPLACE the `box.space.leases.index.expiry_time`\n scan (L302-309) with a scan of `deadlines`: collect ids where\n `deadline \u003c= now`. Plain full-table scan is fine (numeric compares in Lua,\n runs every 500ms); a min-heap (etcd's leaseExpiredNotifier shape) is the\n optional optimization if lease counts get large. revoke() already nils the\n map entry on success.\n\n=== REBUILD ON PROMOTE ===\nAdd lease.M.rebuild_deadlines():\n clears `deadlines`, then for each tuple in box.space.leases:pairs() sets\n deadlines[tuple.id] = clock.monotonic() + tuple.ttl\nCall it in the RW branch of the box.watch('box.status', ...) callback in\napp/roles/etcd.lua (L341-353), immediately before lease.start_expiry().\nThis resets every inherited lease's deadline to a full-TTL grace period on the\nnew leader — exactly etcd's failover behavior.\n\n=== LATENT BUG THIS ALSO FIXES ===\nexpiry_time is currently computed as clock.monotonic()+ttl and REPLICATED.\nclock.monotonic() is process-local (relative to boot), so the persisted value\nis meaningless on any other node. Today a promoted replica's fiber scans\ninherited expiry_time values from a different monotonic timeline — could\nexpire leases instantly or never. Rebuild-on-promote with the new leader's own\nclock removes this entirely."}NULL2026-05-20T07:39:02Z
dcd911a2-525b-42a5-ba99-d233997fc980tarantool-etcd-kbccreatedEugene BlikhNULL2026-05-19T17:11:01Z
df888647-1004-458a-ab8c-f20d22c88a16tarantool-etcd-16dcreatedEugene BlikhNULL2026-05-20T08:47:58Z
dfa2b7f3-da7b-4bed-b088-cf7c47f382ectarantool-etcd-9arcreatedEugene BlikhNULL2026-05-19T17:54:46Z
e91e2679-fee3-46d9-8484-85e92b91b5f6tarantool-etcd-216createdEugene BlikhNULL2026-05-19T17:54:37Z
ed0c9b90-0a6d-4bfa-a337-7c8a4e6741cbtarantool-etcd-35ycreatedEugene BlikhNULL2026-05-20T09:31:01Z
eedfcc8b-a1c9-45c3-af4a-4ad6e93734b9tarantool-etcd-w6zcreatedEugene BlikhNULL2026-05-19T17:54:44Z
f42ad239-ccf4-40f5-91a1-988037ff1187tarantool-etcd-rzrcreatedEugene BlikhNULL2026-05-19T16:34:41Z
f5810a11-b5ec-4ea8-a8c2-b7280c76e945tarantool-etcd-bolcreatedEugene BlikhNULL2026-05-19T17:54:11Z
f7b9bda6-1670-46e7-b453-60afc8055567tarantool-etcd-3dkcreatedEugene BlikhNULL2026-05-19T17:53:55Z
f88c8e63-910c-41ac-ab6c-cefc6d3fa51dtarantool-etcd-ozmcreatedEugene BlikhNULL2026-05-19T17:54:08Z
fae764ad-15c4-41e2-bb69-4678fa232a21tarantool-etcd-a4vcreatedEugene BlikhNULL2026-05-19T17:54:02Z
fc355883-8115-4ca6-9602-dc8456aea6detarantool-etcd-hlxcreatedEugene BlikhNULL2026-05-20T09:17:54Z
fd70bc1d-c816-436b-9672-fb158ba1b5fdtarantool-etcd-tf0createdEugene BlikhNULL2026-05-19T17:54:38Z
fd9da391-204a-4bbd-a474-ae4feec410a2tarantool-etcd-ns0createdEugene BlikhNULL2026-05-19T17:54:34Z
fdac6be5-c569-4565-a3cc-95c9ebdd2109tarantool-etcd-m0wcreatedEugene BlikhNULL2026-05-19T17:54:17Z