main · last commit
1 month ago ·
2npkec0r
tarantool-etcd-1kp /health is a hardcoded constant — can never report unhealthy
Lined Up
bd update tarantool-etcd-1kp --claim
bd close tarantool-etcd-1kp
| Created by | Eugene Blikh |
| Owner | bigbes@gmail.com |
| Created | 2026-07-17T13:21:25Z |
| Updated | 2026-07-17T13:21:25Z |
etcd reports unhealthy on an active alarm or no leader, supports ?exclude=NOSPACE, and implements the probe as a real v3 linearizable range with its own timeout.
app/etcd/json.lua:477-483 ALWAYS returns 200 {"health":"true","reason":""}. The body SHAPE matches 3.5 exactly (string-typed health, reason, no errors field), and the query string is split off (lib/http1/server.lua:230) so ?exclude= parses as a path match but is never interpreted.
Impact: a leaderless rs3 node reports healthy. Any load balancer or k8s probe pointed at /health gets a liveness signal that cannot fail — arguably worse than having no endpoint, since it actively asserts health.
/health returns health=false with a reason when the node has no leader; a self-probe range backs the answer; ?exclude= parsed; test covers the leaderless case.
No outgoing dependencies.
Nothing depends on this issue.
| id | tarantool-etcd-1kp |
| content_hash | 5cf23f484926a3e4bf453927a82a75a629ba2397db6094408d8d080208fa4f3f |
| title | /health is a hardcoded constant — can never report unhealthy |
| description | etcd reports unhealthy on an active alarm or no leader, supports ?exclude=NOSPACE, and implements the probe as a real v3 linearizable range with its own timeout. app/etcd/json.lua:477-483 ALWAYS returns 200 {"health":"true","reason":""}. The body SHAPE matches 3.5 exactly (string-typed health, reason, no errors field), and the query string is split off (lib/http1/server.lua:230) so ?exclude= parses as a path match but is never interpreted. Impact: a leaderless rs3 node reports healthy. Any load balancer or k8s probe pointed at /health gets a liveness signal that cannot fail — arguably worse than having no endpoint, since it actively asserts health. |
| design | |
| acceptance_criteria | /health returns health=false with a reason when the node has no leader; a self-probe range backs the answer; ?exclude= parsed; test covers the leaderless case. |
| notes | |
| status | open |
| priority | 2 |
| issue_type | bug |
| assignee | NULL |
| estimated_minutes | NULL |
| created_at | 2026-07-17T13:21:25Z |
| created_by | Eugene Blikh |
| owner | bigbes@gmail.com |
| updated_at | 2026-07-17T13:21:25Z |
| closed_at | NULL |
| closed_by_session | |
| external_ref | NULL |
| spec_id | |
| compaction_level | 0 |
| compacted_at | NULL |
| compacted_at_commit | NULL |
| original_size | NULL |
| sender | |
| ephemeral | 0 |
| wisp_type | |
| pinned | 0 |
| is_template | 0 |
| mol_type | |
| work_type | |
| source_system | |
| metadata | <binary> |
| source_repo | |
| close_reason | |
| event_kind | |
| actor | |
| target | |
| payload | |
| await_type | |
| await_id | |
| timeout_ns | 0 |
| waiters | |
| hook_bead | |
| role_bead | |
| agent_state | |
| last_activity | NULL |
| role_type | |
| rig | |
| due_at | NULL |
| defer_until | NULL |
| no_history | 0 |
| started_at | NULL |
| is_blocked | 0 |
| issue_id | tarantool-etcd-1kp |
| label | etcd-changelog-sweep |
| id | 019f703d-2c62-7e63-a9d5-71d76bd93d0a |
| issue_id | tarantool-etcd-1kp |
| event_type | created |
| actor | Eugene Blikh |
| old_value | |
| new_value | |
| comment | NULL |
| created_at | 2026-07-17T16:21:25Z |
| id | 019f703d-2c63-7a12-b5a2-5aafe074be17 |
| issue_id | tarantool-etcd-1kp |
| event_type | label_added |
| actor | Eugene Blikh |
| old_value | NULL |
| new_value | NULL |
| comment | Added label: etcd-changelog-sweep |
| created_at | 2026-07-17T16:21:25Z |
No comments.