~bigbes/tarantool-etcd · parade

main · last commit 1 month ago · 2npkec0r

← Back to the parade

tarantool-etcd-1qa Compact(Physical=true) is silently a no-op Lined Up

status: open P4 task milestone:m1-conformance
bd update tarantool-etcd-1qa --claim bd close tarantool-etcd-1qa
Created byEugene Blikh
Ownerbigbes@gmail.com
Created2026-05-20T11:59:03Z
Updated2026-05-20T11:59:03Z
Description
etcd's Compact accepts a Physical flag; on real etcd Physical=true blocks until the underlying bbolt compaction physically reclaims space. tarantool-etcd accepts the flag but ignores it (app/etcd/compact.lua + app/etcd/grpc.lua wiring). Single-node Tarantool compacts synchronously, so the client-observable contract ('no historical revision below the compact point is recoverable after the response returns') is already met regardless of Physical. Hence: probably leave as-is, not blocking conformance — TestKVCompactTable/Physical passes by covering the same end-state. Documented divergence in docs/TODO.md:95. Migrated from the (now-deleted) tests/conformance/GAPS.md Gap 5.
Notes
Deliberate divergence, low priority. Only act if a client needs to distinguish physical reclamation timing; would require modeling an async compaction step that doesn't exist single-node.

Depends on

No outgoing dependencies.

Depended on by

Nothing depends on this issue.

No comments.

  • Eugene Blikh created the issue · 2026-05-20T14:59:03Z
  • Eugene Blikh added label milestone:m1-conformance · 2026-05-21T14:37:02Z
Stored rows — what this pane was built from, as read
issues 1 row
id tarantool-etcd-1qa
content_hash 2cabbe0c40b6d7a881e5a0c5c93427d243b627c4662a16a40db478e29ffd07c7
title Compact(Physical=true) is silently a no-op
description etcd's Compact accepts a Physical flag; on real etcd Physical=true blocks until the underlying bbolt compaction physically reclaims space. tarantool-etcd accepts the flag but ignores it (app/etcd/compact.lua + app/etcd/grpc.lua wiring). Single-node Tarantool compacts synchronously, so the client-observable contract ('no historical revision below the compact point is recoverable after the response returns') is already met regardless of Physical. Hence: probably leave as-is, not blocking conformance — TestKVCompactTable/Physical passes by covering the same end-state. Documented divergence in docs/TODO.md:95. Migrated from the (now-deleted) tests/conformance/GAPS.md Gap 5.
design
acceptance_criteria
notes Deliberate divergence, low priority. Only act if a client needs to distinguish physical reclamation timing; would require modeling an async compaction step that doesn't exist single-node.
status open
priority 4
issue_type task
assignee NULL
estimated_minutes NULL
created_at 2026-05-20T11:59:03Z
created_by Eugene Blikh
owner bigbes@gmail.com
updated_at 2026-05-20T11:59:03Z
closed_at NULL
closed_by_session
external_ref NULL
spec_id
compaction_level 0
compacted_at NULL
compacted_at_commit NULL
original_size NULL
sender
ephemeral 0
wisp_type
pinned 0
is_template 0
mol_type
work_type
source_system
metadata <binary>
source_repo
close_reason
event_kind
actor
target
payload
await_type
await_id
timeout_ns 0
waiters
hook_bead
role_bead
agent_state
last_activity NULL
role_type
rig
due_at NULL
defer_until NULL
no_history 0
started_at NULL
is_blocked 0
labels 1 row
issue_id tarantool-etcd-1qa
label milestone:m1-conformance
events 2 rows
id 2f276f77-e202-54ef-b062-c93aca3cecad
issue_id tarantool-etcd-1qa
event_type created
actor Eugene Blikh
old_value
new_value
comment NULL
created_at 2026-05-20T14:59:03Z
id 6c906929-d9ff-5569-9b6b-981cca35ec32
issue_id tarantool-etcd-1qa
event_type label_added
actor Eugene Blikh
old_value NULL
new_value NULL
comment Added label: milestone:m1-conformance
created_at 2026-05-21T14:37:02Z